Use get_typlenbyvalalign() for JSONB

Nikita Glukhov · Nikita Glukhov · commit 1777de801984 · 2022-03-11T00:52:05.000+03:00
diff --git a/src/backend/utils/adt/jsonb_typanalyze.c b/src/backend/utils/adt/jsonb_typanalyze.c
@@ -1327,11 +1327,11 @@ compute_json_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,
 				jsonAnalyzeMakeStats(&ctx, &stats->numvalues[empty_slot]);
 
 		/* We are storing jsonb values */
-		/* XXX Could the parameters be different on other platforms? */
 		stats->statypid[empty_slot] = JSONBOID;
-		stats->statyplen[empty_slot] = -1;
-		stats->statypbyval[empty_slot] = false;
-		stats->statypalign[empty_slot] = 'i';
+		get_typlenbyvalalign(stats->statypid[empty_slot],
+							 &stats->statyplen[empty_slot],
+							 &stats->statypbyval[empty_slot],
+							 &stats->statypalign[empty_slot]);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1327,11 +1327,11 @@ compute_json_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,`
`1327`	`1327`	`jsonAnalyzeMakeStats(&ctx, &stats->numvalues[empty_slot]);`
`1328`	`1328`
`1329`	`1329`	`/* We are storing jsonb values */`
`1330`		`- /* XXX Could the parameters be different on other platforms? */`
`1331`	`1330`	`stats->statypid[empty_slot] = JSONBOID;`
`1332`		`- stats->statyplen[empty_slot] = -1;`
`1333`		`- stats->statypbyval[empty_slot] = false;`
`1334`		`- stats->statypalign[empty_slot] = 'i';`
	`1331`	`+ get_typlenbyvalalign(stats->statypid[empty_slot],`
	`1332`	`+ &stats->statyplen[empty_slot],`
	`1333`	`+ &stats->statypbyval[empty_slot],`
	`1334`	`+ &stats->statypalign[empty_slot]);`
`1335`	`1335`	`}`
`1336`	`1336`	`}`
`1337`	`1337`