Give a more intelligible and useful error message for SELECT with no

tglsfdc · tglsfdc · commit 1c2d2dbb6772 · 2001-11-13T02:05:27.000Z
destination in plpgsql.
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -3,7 +3,7 @@
  *			  procedural language
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.50 2001/11/08 20:37:52 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.51 2001/11/13 02:05:27 tgl Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -2045,7 +2045,8 @@ exec_stmt_execsql(PLpgSQL_execstate * estate,
 			break;
 
 		case SPI_OK_SELECT:
-			elog(ERROR, "unexpected SELECT query in exec_stmt_execsql()");
+			elog(ERROR, "SELECT query has no destination for result data."
+				 "\n\tIf you want to discard the results, use PERFORM instead.");
 
 		default:
 			elog(ERROR, "error executing query \"%s\"",

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* procedural language`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $Header: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.50 2001/11/08 20:37:52 momjian Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.51 2001/11/13 02:05:27 tgl Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -2045,7 +2045,8 @@ exec_stmt_execsql(PLpgSQL_execstate * estate,`
`2045`	`2045`	`break;`
`2046`	`2046`
`2047`	`2047`	`case SPI_OK_SELECT:`
`2048`		`- elog(ERROR, "unexpected SELECT query in exec_stmt_execsql()");`
	`2048`	`+ elog(ERROR, "SELECT query has no destination for result data."`
	`2049`	`+ "\n\tIf you want to discard the results, use PERFORM instead.");`
`2049`	`2050`
`2050`	`2051`	`default:`
`2051`	`2052`	`elog(ERROR, "error executing query \"%s\"",`