Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 1c8c656

Browse files
committed
Check that all aliases of a built-in function have same leakproof property.
opr_sanity.sql has a test checking that relevant properties of built-in functions match when the same C function is referenced by multiple pg_proc entries. The test neglected to check proleakproof, though, and when I added that condition it exposed that xideqint4 hadn't been updated to match xideq. So fix that as well, and in consequence bump catversion. This isn't very critical, so no need to worry about fixing back branches.
1 parent c07d8c9 commit 1c8c656

File tree

4 files changed

+5
-2
lines changed

4 files changed

+5
-2
lines changed

src/include/catalog/catversion.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@
5353
*/
5454

5555
/* yyyymmddN */
56-
#define CATALOG_VERSION_NO 201505231
56+
#define CATALOG_VERSION_NO 201505291
5757

5858
#endif

src/include/catalog/pg_proc.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1512,7 +1512,7 @@ DESCR("length");
15121512
DATA(insert OID = 1318 ( length PGNSP PGUID 12 1 0 0 0 f f f f t f i 1 0 23 "1042" _null_ _null_ _null_ _null_ _null_ bpcharlen _null_ _null_ _null_ ));
15131513
DESCR("character length");
15141514

1515-
DATA(insert OID = 1319 ( xideqint4 PGNSP PGUID 12 1 0 0 0 f f f f t f i 2 0 16 "28 23" _null_ _null_ _null_ _null_ _null_ xideq _null_ _null_ _null_ ));
1515+
DATA(insert OID = 1319 ( xideqint4 PGNSP PGUID 12 1 0 0 0 f f f t t f i 2 0 16 "28 23" _null_ _null_ _null_ _null_ _null_ xideq _null_ _null_ _null_ ));
15161516

15171517
DATA(insert OID = 1326 ( interval_div PGNSP PGUID 12 1 0 0 0 f f f f t f i 2 0 1186 "1186 701" _null_ _null_ _null_ _null_ _null_ interval_div _null_ _null_ _null_ ));
15181518

src/test/regress/expected/opr_sanity.out

+2
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ WHERE p1.oid < p2.oid AND
130130
(p1.prolang != p2.prolang OR
131131
p1.proisagg != p2.proisagg OR
132132
p1.prosecdef != p2.prosecdef OR
133+
p1.proleakproof != p2.proleakproof OR
133134
p1.proisstrict != p2.proisstrict OR
134135
p1.proretset != p2.proretset OR
135136
p1.provolatile != p2.provolatile OR
@@ -572,6 +573,7 @@ interval_gt(interval,interval)
572573
charlt("char","char")
573574
tidne(tid,tid)
574575
tideq(tid,tid)
576+
xideqint4(xid,integer)
575577
timetz_eq(time with time zone,time with time zone)
576578
timetz_ne(time with time zone,time with time zone)
577579
timetz_lt(time with time zone,time with time zone)

src/test/regress/sql/opr_sanity.sql

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ WHERE p1.oid < p2.oid AND
118118
(p1.prolang != p2.prolang OR
119119
p1.proisagg != p2.proisagg OR
120120
p1.prosecdef != p2.prosecdef OR
121+
p1.proleakproof != p2.proleakproof OR
121122
p1.proisstrict != p2.proisstrict OR
122123
p1.proretset != p2.proretset OR
123124
p1.provolatile != p2.provolatile OR

0 commit comments

Comments
 (0)