Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 1f542a2

Browse files
committed
Prevent planagg.c from failing on queries containing CTEs.
The existing tests in preprocess_minmax_aggregates() usually prevent it from trying to do anything with queries containing CTEs, but there's an exception: a CTE could be present as a member of an appendrel, if we flattened a UNION ALL that contains CTE references. If it did try to generate an optimized path for a query using a CTE, it failed with "could not find plan for CTE", as reported by Torsten Förtsch. The proximate cause is an unwise decision in commit 3fc6e2d to clear subroot->cte_plan_ids in build_minmax_path(). That left the subroot's cte_plan_ids list out of step with its parse->cteList. Removing the "subroot->cte_plan_ids = NIL;" assignment is enough to let the case work again, but really it's pretty silly to be expending any cycles at all in this module when there are CTEs: we always treat their outputs as unordered so there's no way for the optimization to win. Hence, also add an early-exit test so we don't waste time like that. Back-patch to 9.6 where the misbehavior was introduced. Report: https://postgr.es/m/CAKkG4_=gjY5QiHtqSZyWMwDuTd_CftKoTaCqxjJ7uUz1-Gw=qw@mail.gmail.com
1 parent 501c7b9 commit 1f542a2

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/backend/optimizer/plan/planagg.c

+8-1
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,14 @@ preprocess_minmax_aggregates(PlannerInfo *root, List *tlist)
103103
parse->hasWindowFuncs)
104104
return;
105105

106+
/*
107+
* Reject if query contains any CTEs; there's no way to build an indexscan
108+
* on one so we couldn't succeed here. (If the CTEs are unreferenced,
109+
* that's not true, but it doesn't seem worth expending cycles to check.)
110+
*/
111+
if (parse->cteList)
112+
return;
113+
106114
/*
107115
* We also restrict the query to reference exactly one table, since join
108116
* conditions can't be handled reasonably. (We could perhaps handle a
@@ -360,7 +368,6 @@ build_minmax_path(PlannerInfo *root, MinMaxAggInfo *mminfo,
360368
subroot->plan_params = NIL;
361369
subroot->outer_params = NULL;
362370
subroot->init_plans = NIL;
363-
subroot->cte_plan_ids = NIL;
364371

365372
subroot->parse = parse = (Query *) copyObject(root->parse);
366373
IncrementVarSublevelsUp((Node *) parse, 1, 1);

0 commit comments

Comments
 (0)