Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 22a67fd

Browse files
committed
Simplify tab completion of extension versions, redux.
After commit 662dbe2, psql tab completion didn't conveniently support the case of "ALTER EXTENSION foo UPDATE". It'd always add "TO", which is fine if you want to specify a target version but not if you don't ... and surely the latter is the much more common case. To fix, remove "TO" from the initially offered completion; you now need to press TAB one additional time to get that. We won't try to duplicate the old behavior of attempting initial completion on the target version along with TO. It's too squirrelly to get the quoting right, and this is such an infrequent usage that it doesn't seem worth expending a lot of effort and special code on. Noted by Noah Misch. Back-patch to v15. Discussion: https://postgr.es/m/20220703083217.GB2476530@rfd.leadboat.com
1 parent 5faef9d commit 22a67fd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bin/psql/tab-complete.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1927,7 +1927,7 @@ psql_completion(const char *text, int start, int end)
19271927

19281928
/* ALTER EXTENSION <name> */
19291929
else if (Matches("ALTER", "EXTENSION", MatchAny))
1930-
COMPLETE_WITH("ADD", "DROP", "UPDATE TO", "SET SCHEMA");
1930+
COMPLETE_WITH("ADD", "DROP", "UPDATE", "SET SCHEMA");
19311931

19321932
/* ALTER EXTENSION <name> UPDATE */
19331933
else if (Matches("ALTER", "EXTENSION", MatchAny, "UPDATE"))

0 commit comments

Comments
 (0)