Fixed elog 'connection to myself...'

arssher · arssher · commit 240f19aecbe8 · 2017-09-29T16:09:08.000+03:00
diff --git a/src/udf.c b/src/udf.c
@@ -413,13 +413,13 @@ alter_system_c(PG_FUNCTION_ARGS)
 	connstr = SPI_getvalue(SPI_tuptable->vals[0], SPI_tuptable->tupdesc, 1);
 
 	conn = PQconnectdb(connstr);
-	SPI_finish(); /* Can't do earlier since connstr is allocated there */
 	if (PQstatus(conn) != CONNECTION_OK)
 	{
 		PQfinish(conn);
 		elog(ERROR, "Connection to myself with connstr %s failed", connstr);
 
 	}
+	SPI_finish(); /* Can't do earlier since connstr is allocated there */
 	res = PQexec(conn, cmd);
 	if (PQresultStatus(res) != PGRES_COMMAND_OK)
 	{

Original file line number	Diff line number	Diff line change
`@@ -413,13 +413,13 @@ alter_system_c(PG_FUNCTION_ARGS)`
`413`	`413`	`connstr = SPI_getvalue(SPI_tuptable->vals[0], SPI_tuptable->tupdesc, 1);`
`414`	`414`
`415`	`415`	`conn = PQconnectdb(connstr);`
`416`		`- SPI_finish(); /* Can't do earlier since connstr is allocated there */`
`417`	`416`	`if (PQstatus(conn) != CONNECTION_OK)`
`418`	`417`	`{`
`419`	`418`	`PQfinish(conn);`
`420`	`419`	`elog(ERROR, "Connection to myself with connstr %s failed", connstr);`
`421`	`420`
`422`	`421`	`}`
	`422`	`+ SPI_finish(); /* Can't do earlier since connstr is allocated there */`
`423`	`423`	`res = PQexec(conn, cmd);`
`424`	`424`	`if (PQresultStatus(res) != PGRES_COMMAND_OK)`
`425`	`425`	`{`