Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 24dd050

Browse files
committed
Update comments for elog_start().
Forgot I was going to do this as part of the previous patch ...
1 parent b853eb9 commit 24dd050

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/backend/utils/error/elog.c

+5-4
Original file line numberDiff line numberDiff line change
@@ -1156,12 +1156,13 @@ getinternalerrposition(void)
11561156
* elog_start --- startup for old-style API
11571157
*
11581158
* All that we do here is stash the hidden filename/lineno/funcname
1159-
* arguments into a stack entry.
1159+
* arguments into a stack entry, along with the current value of errno.
11601160
*
11611161
* We need this to be separate from elog_finish because there's no other
1162-
* portable way to deal with inserting extra arguments into the elog call.
1163-
* (If macros with variable numbers of arguments were portable, it'd be
1164-
* easy, but they aren't.)
1162+
* C89-compliant way to deal with inserting extra arguments into the elog
1163+
* call. (When using C99's __VA_ARGS__, we could possibly merge this with
1164+
* elog_finish, but there doesn't seem to be a good way to save errno before
1165+
* evaluating the format arguments if we do that.)
11651166
*/
11661167
void
11671168
elog_start(const char *filename, int lineno, const char *funcname)

0 commit comments

Comments
 (0)