Fix for plpython functions; return true/false for boolean,

bmomjian · bmomjian · commit 251281767a9b · 2007-01-25T04:08:51.000Z
rather than 1/0.  This helps when creating trigger functions that output
SQL.

Guido Goldstein
diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plpython.c - python as a procedural language for PostgreSQL
  *
- *	$PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.90 2006/11/21 21:51:05 tgl Exp $
+ *	$PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.91 2007/01/25 04:08:51 momjian Exp $
  *
  *********************************************************************
  */
@@ -1580,8 +1580,8 @@ static PyObject *
 PLyBool_FromString(const char *src)
 {
 	if (src[0] == 't')
-		return PyInt_FromLong(1);
-	return PyInt_FromLong(0);
+		Py_RETURN_TRUE;
+	Py_RETURN_FALSE;
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/**********************************************************************`
`2`	`2`	`* plpython.c - python as a procedural language for PostgreSQL`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.90 2006/11/21 21:51:05 tgl Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.91 2007/01/25 04:08:51 momjian Exp $`
`5`	`5`	`*`
`6`	`6`	`*********************************************************************`
`7`	`7`	`*/`
`@@ -1580,8 +1580,8 @@ static PyObject *`
`1580`	`1580`	`PLyBool_FromString(const char *src)`
`1581`	`1581`	`{`
`1582`	`1582`	`if (src[0] == 't')`
`1583`		`- return PyInt_FromLong(1);`
`1584`		`- return PyInt_FromLong(0);`
	`1583`	`+ Py_RETURN_TRUE;`
	`1584`	`+ Py_RETURN_FALSE;`
`1585`	`1585`	`}`
`1586`	`1586`
`1587`	`1587`	`static PyObject *`