Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 25cb776

Browse files
committed
meson: Improve dependencies for tmp_install test target
The missing dependency was, e.g., visible when doing ninja clean && ninja meson-test-prereq && meson test --no-rebuild --suite setup --suite cube because meson (and thus its internal meson-test-prereq target) did not know about a lot of the required targets. Previously tmp_install did not actually depend on the relevant files being built. That was mostly not visible, because "meson test" currently uses the 'default' targets as a test's dependency if no dependency is specified. However, there are plans to narrow that on the meson side, to make it quicker to run tests. Apply this to all branches with meson support, as part of an effort to fix incorrect test dependencies that can lead to test failures. Discussion: https://postgr.es/m/CAGECzQSvM3iSDmjF+=Kof5an6jN8UbkP_4cKKT9w6GZavmb5yQ@mail.gmail.com Discussion: https://postgr.es/m/bdba588f-69a9-4f3e-9b95-62d07210a32e@eisentraut.org Backpatch: 16-, where meson support was added
1 parent 6a4815c commit 25cb776

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

meson.build

+1
Original file line numberDiff line numberDiff line change
@@ -3317,6 +3317,7 @@ test('tmp_install',
33173317
priority: setup_tests_priority,
33183318
timeout: 300,
33193319
is_parallel: false,
3320+
depends: installed_targets,
33203321
suite: ['setup'])
33213322

33223323
test('install_test_files',

0 commit comments

Comments
 (0)