Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 293fd24

Browse files
committed
ecpg: remove check_rules.pl.
As noted in the previous commit, check_rules.pl is now entirely redundant with checks made by parse.pl, or would be if it weren't for the places where it's wrong. It's a waste of build cycles and maintenance effort, so remove it. Discussion: https://postgr.es/m/2011420.1713493114@sss.pgh.pa.us
1 parent 00b0e72 commit 293fd24

File tree

3 files changed

+1
-219
lines changed

3 files changed

+1
-219
lines changed

src/interfaces/ecpg/preproc/Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ preproc.h: preproc.c
6464

6565
preproc.c: BISONFLAGS += -d
6666

67-
preproc.y: ../../../backend/parser/gram.y parse.pl check_rules.pl ecpg.addons ecpg.header ecpg.tokens ecpg.trailer ecpg.type
68-
$(PERL) $(srcdir)/check_rules.pl --srcdir $(srcdir) --parser $<
67+
preproc.y: ../../../backend/parser/gram.y parse.pl ecpg.addons ecpg.header ecpg.tokens ecpg.trailer ecpg.type
6968
$(PERL) $(srcdir)/parse.pl --srcdir $(srcdir) --parser $< --output $@
7069

7170
# generate keyword headers

src/interfaces/ecpg/preproc/check_rules.pl

Lines changed: 0 additions & 202 deletions
This file was deleted.

src/interfaces/ecpg/preproc/meson.build

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -44,20 +44,6 @@ preproc_y = custom_target('preproc.y',
4444
)
4545
generated_sources += preproc_y
4646

47-
check_rules = custom_target('preproc.y.check_rules',
48-
input: [
49-
'../../../backend/parser/gram.y',
50-
ecpg_files,
51-
],
52-
output: 'preproc.y.check_rules',
53-
command: [
54-
perl, files('check_rules.pl'),
55-
'--srcdir', '@CURRENT_SOURCE_DIR@',
56-
'--parser', '@INPUT0@',
57-
'--stamp', '@OUTPUT0@',
58-
],
59-
)
60-
6147
preproc = custom_target('preproc.c',
6248
input: preproc_y,
6349
kwargs: bison_kw,
@@ -68,7 +54,6 @@ ecpg_sources += preproc
6854
c_kwlist = custom_target('c_kwlist_d.h',
6955
input: ['c_kwlist.h'],
7056
output: ['c_kwlist_d.h'],
71-
depends: check_rules,
7257
depend_files: gen_kwlist_deps,
7358
command: [gen_kwlist_cmd, '--varname', 'ScanCKeywords', '--no-case-fold'],
7459
)

0 commit comments

Comments
 (0)