Correct statement to actually be the intended assert statement.

anarazel · anarazel · commit 2a3544960eaa · 2015-12-14T11:23:24.000+01:00
e3f4cfc introduced a LWLockHeldByMe() call, without the corresponding Assert() surrounding it. Spotted by Coverity. Backpatch: 9.1+, like the previous commit
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
@@ -3004,7 +3004,7 @@ FlushOneBuffer(Buffer buffer)
 
 	bufHdr = GetBufferDescriptor(buffer - 1);
 
-	LWLockHeldByMe(bufHdr->content_lock);
+	Assert(LWLockHeldByMe(bufHdr->content_lock));
 
 	FlushBuffer(bufHdr, NULL);
 }

Original file line number	Diff line number	Diff line change
`@@ -3004,7 +3004,7 @@ FlushOneBuffer(Buffer buffer)`
`3004`	`3004`
`3005`	`3005`	`bufHdr = GetBufferDescriptor(buffer - 1);`
`3006`	`3006`
`3007`		`- LWLockHeldByMe(bufHdr->content_lock);`
	`3007`	`+ Assert(LWLockHeldByMe(bufHdr->content_lock));`
`3008`	`3008`
`3009`	`3009`	`FlushBuffer(bufHdr, NULL);`
`3010`	`3010`	`}`