Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 2ad422c

Browse files
committed
Remove abstime, reltime, tinterval tables from old regression databases.
In the back branches, drop these tables after the regression tests are done with them. This fixes failures of cross-branch pg_upgrade testing caused by these types having been removed in v12. We do lose the ability to test dump/restore behavior with these types in the back branches, but the actual loss of code coverage seems to be nil given that there's nothing very special about these types. Discussion: https://postgr.es/m/20181009192237.34wjp3nmw7oynmmr@alap3.anarazel.de
1 parent a88482d commit 2ad422c

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

src/test/regress/expected/horology.out

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3040,3 +3040,10 @@ SELECT to_char('2012-12-12 12:00'::timestamptz, 'YYYY-MM-DD HH:MI:SS TZ');
30403040
(1 row)
30413041

30423042
RESET TIME ZONE;
3043+
--
3044+
-- Drop tables that we don't want to keep because they interfere with
3045+
-- testing pg_upgrade to v12 and up
3046+
--
3047+
DROP TABLE abstime_tbl;
3048+
DROP TABLE reltime_tbl;
3049+
DROP TABLE tinterval_tbl;

src/test/regress/expected/sanity_check.out

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ SELECT relname, relhasindex
1313
ORDER BY relname;
1414
a|f
1515
a_star|f
16-
abstime_tbl|f
1716
aggtest|f
1817
array_index_op_test|t
1918
array_op_test|f
@@ -148,7 +147,6 @@ quad_point_tbl|t
148147
radix_text_tbl|t
149148
ramp|f
150149
real_city|f
151-
reltime_tbl|f
152150
road|t
153151
shighway|t
154152
slow_emp4000|f
@@ -173,7 +171,6 @@ time_tbl|f
173171
timestamp_tbl|f
174172
timestamptz_tbl|f
175173
timetz_tbl|f
176-
tinterval_tbl|f
177174
varchar_tbl|f
178175
-- restore normal output mode
179176
\a\t

src/test/regress/sql/horology.sql

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,3 +497,12 @@ SELECT '2012-12-12 12:00 America/New_York'::timestamptz;
497497
SELECT to_char('2012-12-12 12:00'::timestamptz, 'YYYY-MM-DD HH:MI:SS TZ');
498498

499499
RESET TIME ZONE;
500+
501+
--
502+
-- Drop tables that we don't want to keep because they interfere with
503+
-- testing pg_upgrade to v12 and up
504+
--
505+
506+
DROP TABLE abstime_tbl;
507+
DROP TABLE reltime_tbl;
508+
DROP TABLE tinterval_tbl;

0 commit comments

Comments
 (0)