Fixed possibly unsafe memcpy() in scheduler_manager.c

1) Changed memcpy() to strcpy() to make sure
that we copy the string with '\0' in the end

2) Added a strlen check to make sure that we
don't try to copy a string that is too long
into a fixed-length array of chars

Author: anna-akenteva

src/scheduler_manager.c

@@ -946,8 +946,21 @@ int launch_executor_worker(scheduler_manager_ctx_t *ctx, scheduler_manager_slot_
 void init_executor_shared_data(schd_executor_share_t *data, scheduler_manager_ctx_t *ctx, job_t *job)
 {
 	data->status = SchdExecutorInit;
-	memcpy(data->database, ctx->database, strlen(ctx->database));
-	memcpy(data->nodename, job->node, strlen(job->node));
+
+	if(strlen(ctx->database) < PGPRO_SCHEDULER_DBNAME_MAX)
+		strcpy(data->database, ctx->database);
+	else
+		elog(ERROR, "String \"%s\"\n"
+				    "has %zu symbols, while it should have less than %d symbols.",
+					ctx->database, strlen(ctx->database), PGPRO_SCHEDULER_DBNAME_MAX);
+
+	if(strlen(job->node) < PGPRO_SCHEDULER_NODENAME_MAX)
+		strcpy(data->nodename, job->node);
+	else
+		elog(ERROR, "String \"%s\"\n"
+				    "has %zu symbols, while it should have less than %d symbols.",
+					job->node, strlen(job->node), PGPRO_SCHEDULER_NODENAME_MAX);
+
 	data->new_job = true;
 
 	if(job)
@@ -1775,8 +1788,20 @@ int start_at_worker(scheduler_manager_ctx_t *ctx, int pos)
 	item->res_owner = CurrentResourceOwner;
 	shm_data = dsm_segment_address(item->shared);
 
-	memcpy(shm_data->database, ctx->database, strlen(ctx->database));
-	memcpy(shm_data->nodename, ctx->nodename, strlen(ctx->nodename));
+	if(strlen(ctx->database) < PGPRO_SCHEDULER_DBNAME_MAX)
+		strcpy(shm_data->database, ctx->database);
+	else
+		elog(ERROR, "String \"%s\"\n"
+				    "has %zu symbols, while it should have less than %d symbols.",
+					ctx->database, strlen(ctx->database), PGPRO_SCHEDULER_DBNAME_MAX);
+
+	if(strlen(ctx->nodename) < PGPRO_SCHEDULER_NODENAME_MAX)
+		strcpy(shm_data->nodename, ctx->nodename);
+	else
+		elog(ERROR, "String \"%s\"\n"
+				    "has %zu symbols, while it should have less than %d symbols.",
+					ctx->nodename, strlen(ctx->nodename), PGPRO_SCHEDULER_NODENAME_MAX);
+
 	shm_data->stop_worker  = false;
 	shm_data->status  = SchdExecutorInit;
 	shm_data->start_at  = 0;