Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 2e57ffe

Browse files
Skip \password TAP test on old IPC::Run versions
IPC::Run versions prior to 0.98 cause the interactive session to time out, so SKIP the test in case these versions are detected (they are within the base requirement for our TAP tests in general). Error reported by the BF and investigation by Tom Lane. Discussion: https://postgr.es/m/414A86BD-986B-48A7-A1E4-EEBCE5AF08CB@yesql.se
1 parent 0e9b271 commit 2e57ffe

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/test/authentication/t/001_password.pl

+4-2
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,12 @@ sub test_conn
102102
is($res, 'SCRAM-SHA-256$1024:', 'scram_iterations in server side ROLE');
103103

104104
# If we don't have IO::Pty, forget it, because IPC::Run depends on that
105-
# to support pty connections
105+
# to support pty connections. Also skip if IPC::Run isn't at least 0.98
106+
# as earlier version cause the session to time out.
106107
SKIP:
107108
{
108-
skip "IO::Pty required", 1 unless eval { require IO::Pty; };
109+
skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
110+
(eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' });
109111

110112
# Alter the password on the created role using \password in psql to ensure
111113
# that clientside password changes use the scram_iterations value when

0 commit comments

Comments
 (0)