Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 2e83db3

Browse files
committed
Allow pg_ctl kill to send SIGKILL.
Previously that was disallowed out of an abundance of caution. Providing KILL support however is helpful to make the 013_crash_restart.pl test portable, and there's no actual issue with allowing it. SIGABRT, which has similar consequences except it also dumps core, was already allowed. Author: Andres Freund Discussion: https://postgr.es/m/45d42d41-6145-9be1-7261-84acf6d9e344@2ndQuadrant.com
1 parent 5a632a2 commit 2e83db3

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/bin/pg_ctl/pg_ctl.c

+1-4
Original file line numberDiff line numberDiff line change
@@ -1903,7 +1903,7 @@ do_help(void)
19031903
printf(_(" immediate quit without complete shutdown; will lead to recovery on restart\n"));
19041904

19051905
printf(_("\nAllowed signal names for kill:\n"));
1906-
printf(" ABRT HUP INT QUIT TERM USR1 USR2\n");
1906+
printf(" ABRT HUP INT KILL QUIT TERM USR1 USR2\n");
19071907

19081908
#ifdef WIN32
19091909
printf(_("\nOptions for register and unregister:\n"));
@@ -1961,11 +1961,8 @@ set_sig(char *signame)
19611961
sig = SIGQUIT;
19621962
else if (strcmp(signame, "ABRT") == 0)
19631963
sig = SIGABRT;
1964-
#if 0
1965-
/* probably should NOT provide SIGKILL */
19661964
else if (strcmp(signame, "KILL") == 0)
19671965
sig = SIGKILL;
1968-
#endif
19691966
else if (strcmp(signame, "TERM") == 0)
19701967
sig = SIGTERM;
19711968
else if (strcmp(signame, "USR1") == 0)

0 commit comments

Comments
 (0)