Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 306d6e5

Browse files
committed
Fix broken extract_actual_join_clauses call in 9.6 postgres_fdw.
In commits e5d8399 et al, I changed the signature of extract_actual_join_clauses, thinking that it was not called from anywhere but createplan.c. I missed that postgres_fdw uses it in the 9.6 branch only. This opens up the question of whether any third-party modules might be calling it, and whether we need to take steps to avoid an API break for them. But for the moment, just get the buildfarm green again.
1 parent 0c141fc commit 306d6e5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

contrib/postgres_fdw/postgres_fdw.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3976,7 +3976,9 @@ foreign_join_ok(PlannerInfo *root, RelOptInfo *joinrel, JoinType jointype,
39763976

39773977
/* Separate restrict list into join quals and quals on join relation */
39783978
if (IS_OUTER_JOIN(jointype))
3979-
extract_actual_join_clauses(extra->restrictlist, &joinclauses, &otherclauses);
3979+
extract_actual_join_clauses(extra->restrictlist,
3980+
joinrel->relids,
3981+
&joinclauses, &otherclauses);
39803982
else
39813983
{
39823984
/*

0 commit comments

Comments
 (0)