Zeroing unused parts ducring tsquery construction.

feodor · feodor · commit 3308467905aa · 2016-04-07T20:45:24.000+03:00
Per investigation failure skink buildfarm member and
RANDOMIZE_ALLOCATED_MEMORY help
diff --git a/src/backend/utils/adt/tsquery_cleanup.c b/src/backend/utils/adt/tsquery_cleanup.c
@@ -347,7 +347,8 @@ makeNODE(int8 op, NODE *left, NODE *right)
 {
 	NODE *node = palloc(sizeof(NODE));
 
-	node->valnode = palloc(sizeof(QueryItem));
+	/* zeroing allocation to prevent difference in unused bytes */
+	node->valnode = palloc0(sizeof(QueryItem));
 
 	node->valnode->qoperator.type = QI_OPR;
 	node->valnode->qoperator.oper = op;

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,8 @@ makeNODE(int8 op, NODE left, NODE right)`
`347`	`347`	`{`
`348`	`348`	`NODE *node = palloc(sizeof(NODE));`
`349`	`349`
`350`		`- node->valnode = palloc(sizeof(QueryItem));`
	`350`	`+ /* zeroing allocation to prevent difference in unused bytes */`
	`351`	`+ node->valnode = palloc0(sizeof(QueryItem));`
`351`	`352`
`352`	`353`	`node->valnode->qoperator.type = QI_OPR;`
`353`	`354`	`node->valnode->qoperator.oper = op;`