Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 33a4466

Browse files
committed
Fix ordering of obj id for Rules and EventTriggers in pg_dump.
getSchemaData() must identify extension member objects and mark them as not to be dumped. This must happen after reading all objects that can be direct members of extensions, but before we begin to process table subsidiary objects. Both rules and event triggers were wrong in this regard. Backport rules portion of patch to 9.1 -- event triggers do not exist prior to 9.3. Suggested fix by Tom Lane, initial complaint and patch by me.
1 parent e0b451e commit 33a4466

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/bin/pg_dump/common.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ getSchemaData(Archive *fout, int *numTablesPtr)
203203
inhinfo = getInherits(fout, &numInherits);
204204

205205
if (g_verbose)
206-
write_msg(NULL, "reading rewrite rules\n");
207-
getRules(fout, &numRules);
206+
write_msg(NULL, "reading event triggers\n");
207+
getEventTriggers(fout, &numEventTriggers);
208208

209209
/*
210210
* Identify extension member objects and mark them as not to be dumped.
@@ -241,8 +241,8 @@ getSchemaData(Archive *fout, int *numTablesPtr)
241241
getTriggers(fout, tblinfo, numTables);
242242

243243
if (g_verbose)
244-
write_msg(NULL, "reading event triggers\n");
245-
getEventTriggers(fout, &numEventTriggers);
244+
write_msg(NULL, "reading rewrite rules\n");
245+
getRules(fout, &numRules);
246246

247247
*numTablesPtr = numTables;
248248
return tblinfo;

0 commit comments

Comments
 (0)