Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 37d0c2c

Browse files
committed
Fix parallel safety markings for pg_start_backup.
Commit 7117685 made pg_start_backup parallel-restricted rather than parallel-safe, because it now relies on backend-private state that won't be synchronized with the parallel worker. However, it didn't update pg_proc.h. Separately, Andreas Karlsson observed that system_views.sql neglected to reiterate the parallel-safety markings whe redefining various functions, including this one; so add a PARALLEL RESTRICTED declaration there to match the new value in pg_proc.h.
1 parent f2f5e7e commit 37d0c2c

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/backend/catalog/system_views.sql

+2-1
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,8 @@ COMMENT ON FUNCTION ts_debug(text) IS
922922

923923
CREATE OR REPLACE FUNCTION
924924
pg_start_backup(label text, fast boolean DEFAULT false, exclusive boolean DEFAULT true)
925-
RETURNS pg_lsn STRICT VOLATILE LANGUAGE internal AS 'pg_start_backup';
925+
RETURNS pg_lsn STRICT VOLATILE LANGUAGE internal AS 'pg_start_backup'
926+
PARALLEL RESTRICTED;
926927

927928
-- legacy definition for compatibility with 9.3
928929
CREATE OR REPLACE FUNCTION

src/include/catalog/catversion.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@
5353
*/
5454

5555
/* yyyymmddN */
56-
#define CATALOG_VERSION_NO 201604082
56+
#define CATALOG_VERSION_NO 201605021
5757

5858
#endif

src/include/catalog/pg_proc.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -3107,7 +3107,7 @@ DATA(insert OID = 2171 ( pg_cancel_backend PGNSP PGUID 12 1 0 0 0 f f f f t f v
31073107
DESCR("cancel a server process' current query");
31083108
DATA(insert OID = 2096 ( pg_terminate_backend PGNSP PGUID 12 1 0 0 0 f f f f t f v s 1 0 16 "23" _null_ _null_ _null_ _null_ _null_ pg_terminate_backend _null_ _null_ _null_ ));
31093109
DESCR("terminate a server process");
3110-
DATA(insert OID = 2172 ( pg_start_backup PGNSP PGUID 12 1 0 0 0 f f f f t f v s 3 0 3220 "25 16 16" _null_ _null_ _null_ _null_ _null_ pg_start_backup _null_ _null_ _null_ ));
3110+
DATA(insert OID = 2172 ( pg_start_backup PGNSP PGUID 12 1 0 0 0 f f f f t f v r 3 0 3220 "25 16 16" _null_ _null_ _null_ _null_ _null_ pg_start_backup _null_ _null_ _null_ ));
31113111
DESCR("prepare for taking an online backup");
31123112
DATA(insert OID = 2173 ( pg_stop_backup PGNSP PGUID 12 1 0 0 0 f f f f t f v s 0 0 3220 "" _null_ _null_ _null_ _null_ _null_ pg_stop_backup _null_ _null_ _null_ ));
31133113
DESCR("finish taking an online backup");

0 commit comments

Comments
 (0)