Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3845577

Browse files
committed
Fix performance regression in pg_strtointNN_safe functions
Between 6fcda9a and 1b6f632, the pg_strtoint functions became quite a bit slower in v16, despite efforts in 6b423ec to speed these up. Since the majority of cases for these functions will only contain base-10 digits, perhaps prefixed by a '-', it makes sense to have a special case for this and just fall back on the more complex version which processes hex, octal, binary and underscores if the fast path version fails to parse the string. While we're here, update the header comments for these functions to mention that hex, octal and binary formats along with underscore separators are now supported. Author: Andres Freund, David Rowley Reported-by: Masahiko Sawada Reviewed-by: Dean Rasheed, John Naylor Discussion: https://postgr.es/m/CAD21AoDvDmUQeJtZrau1ovnT_smN940%3DKp6mszNGK3bq9yRN6g%40mail.gmail.com Backpatch-through: 16, where 6fcda9a and 1b6f632 were added
1 parent 36ab831 commit 3845577

File tree

1 file changed

+279
-27
lines changed

1 file changed

+279
-27
lines changed

0 commit comments

Comments
 (0)