Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 38c1871

Browse files
committed
Fix pg_upgrade's cross-version tests when old < 18
Because in the 18 cycle we turned checksums on by default with commit 04bec89, and pg_upgrade fails if the setting doesn't match in old and new clusters, the built-in cross-version pg_upgrade test is failing if the old version is older than 18. Fix the script so that it creates the old cluster with checksums enabled (-k) in cross-version scenarios. This went unnoticed because the buildfarm doesn't use the same test code for cross-version testing. Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Discussion: https://postgr.es/m/202411071838.7fgkb7uvavvz@alvherre.pgsql
1 parent f05b5e6 commit 38c1871

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/bin/pg_upgrade/t/002_pg_upgrade.pl

+4
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,10 @@ sub filter_dump
180180
}
181181
}
182182

183+
# Since checksums are now enabled by default, and weren't before 18,
184+
# pass '-k' to initdb on old versions so that upgrades work.
185+
push @initdb_params, '-k' if $oldnode->pg_version < 18;
186+
183187
$node_params{extra} = \@initdb_params;
184188
$oldnode->init(%node_params);
185189
$oldnode->start;

0 commit comments

Comments
 (0)