Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3a36ca0

Browse files
committed
AdjustUpgrade.pm should zap test_ext_cine, too.
test_extensions' test_ext_cine extension has the same upgrade hazard as test_ext7: the regression test leaves it in an updated state from which no downgrade path to default is provided. This causes the update_extensions.sql script helpfully provided by pg_upgrade to fail. So drop it in cross-version-upgrade testing. Not entirely sure how come I didn't hit this in testing yesterday; possibly I'd built the upgrade reference databases with testmodules-install-check disabled. Backpatch to v10 where this module was introduced.
1 parent 2a1d707 commit 3a36ca0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm

+2-1
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,13 @@ sub adjust_database_contents
8888
}
8989
}
9090

91-
# avoid version number issues with test_ext7
91+
# avoid no-path-to-downgrade-extension-version issues
9292
if ($dbnames{contrib_regression_test_extensions})
9393
{
9494
_add_st(
9595
$result,
9696
'contrib_regression_test_extensions',
97+
'drop extension if exists test_ext_cine',
9798
'drop extension if exists test_ext7');
9899
}
99100

0 commit comments

Comments
 (0)