Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3b51265

Browse files
committed
Adjust obsolete comment explaining set_stack_base().
Commit 7389aad removed the notion of backends started from inside a signal handler. A stray comment still referred to them, while explaining the need for a call to set_stack_base(). That leads to the question of whether we still need the call in !EXEC_BACKEND builds. There doesn't seem to be much point in suppressing it now, as it doesn't hurt and probably helps to measure the stack base from the exact same place in EXEC_BACKEND and !EXEC_BACKEND builds. Back-patch to 16. Reported-by: Heikki Linnakangas <hlinnaka@iki.fi> Reported-by: Tristan Partin <tristan@neon.tech> Reported-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/CA%2BhUKG%2BEJHcevNGNOxVWxTNFbuB%3Dvjf4U68%2B85rAC_Sxvy2zEQ%40mail.gmail.com
1 parent f93133a commit 3b51265

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/backend/utils/init/miscinit.c

+2-3
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,8 @@ InitPostmasterChild(void)
107107

108108
/*
109109
* Set reference point for stack-depth checking. This might seem
110-
* redundant in !EXEC_BACKEND builds; but it's not because the postmaster
111-
* launches its children from signal handlers, so we might be running on
112-
* an alternative stack.
110+
* redundant in !EXEC_BACKEND builds, but it's better to keep the depth
111+
* logic the same with and without that build option.
113112
*/
114113
(void) set_stack_base();
115114

0 commit comments

Comments
 (0)