Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3bee0a4

Browse files
committed
Run the "tablespace" regression test first not last. The former placement
renders useless one of the few test methodologies we have for WAL replay, which is to intentionally crash the system just after completing the regression tests and see if it recovers to the expected database state. The reason is that DROP TABLESPACE forces a checkpoint, so there's essentially no WAL available for replay after the tests complete.
1 parent 7fc7a7c commit 3bee0a4

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/test/regress/parallel_schedule

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
# ----------
2-
# $PostgreSQL: pgsql/src/test/regress/parallel_schedule,v 1.56 2009/07/02 07:03:18 petere Exp $
2+
# $PostgreSQL: pgsql/src/test/regress/parallel_schedule,v 1.57 2009/08/24 03:10:16 tgl Exp $
33
#
44
# By convention, we put no more than twenty tests in any one parallel group;
55
# this limits the number of connections needed to run the tests.
66
# ----------
77

8+
# run tablespace by itself, and first, because it forces a checkpoint;
9+
# we'd prefer not to have checkpoints later in the tests because that
10+
# interferes with crash-recovery testing.
11+
test: tablespace
12+
813
# ----------
914
# The first group of parallel tests
1015
# ----------
@@ -89,6 +94,3 @@ test: plancache limit plpgsql copy2 temp domain rangefuncs prepare without_oid c
8994

9095
# run stats by itself because its delay may be insufficient under heavy load
9196
test: stats
92-
93-
# run tablespace by itself
94-
test: tablespace

src/test/regress/serial_schedule

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
# $PostgreSQL: pgsql/src/test/regress/serial_schedule,v 1.53 2009/07/02 07:03:18 petere Exp $
1+
# $PostgreSQL: pgsql/src/test/regress/serial_schedule,v 1.54 2009/08/24 03:10:16 tgl Exp $
22
# This should probably be in an order similar to parallel_schedule.
3+
test: tablespace
34
test: boolean
45
test: char
56
test: name
@@ -121,4 +122,3 @@ test: largeobject
121122
test: with
122123
test: xml
123124
test: stats
124-
test: tablespace

0 commit comments

Comments
 (0)