Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3c85535

Browse files
committed
Re-stabilize infinite_recurse() test case.
Since commit 8f59f6b, CLOBBER_CACHE_ALWAYS buildfarm members have been failing this test case because the error message now sometimes includes an error cursor position. It seems largely just luck that that never happened before, and there are likely to be more ways it could happen in future. Hence, rather than trying to prevent it, adjust the test script to suppress that component of the report. At some point we might need to back-patch this, but refrain until there's a demonstrated need. (We'd need a different fix before v12, anyway, since VERBOSITY=sqlstate is a recent thing.) Tom Lane and Andres Freund Discussion: https://postgr.es/m/30675.1586111599@sss.pgh.pa.us
1 parent f1ac27b commit 3c85535

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/test/regress/expected/errors.out

+6-3
Original file line numberDiff line numberDiff line change
@@ -441,9 +441,12 @@ ERROR: syntax error at or near "NUL"
441441
LINE 16: ...L, id2 TEXT NOT NULL PRIMARY KEY, id3 INTEGER NOT NUL, id4 I...
442442
^
443443
-- Check that stack depth detection mechanism works and
444-
-- max_stack_depth is not set too high
444+
-- max_stack_depth is not set too high. The full error report is not
445+
-- very stable, so show only SQLSTATE and primary error message.
445446
create function infinite_recurse() returns int as
446447
'select infinite_recurse()' language sql;
447-
\set VERBOSITY terse
448+
\set VERBOSITY sqlstate
448449
select infinite_recurse();
449-
ERROR: stack depth limit exceeded
450+
ERROR: 54001
451+
\echo :LAST_ERROR_MESSAGE
452+
stack depth limit exceeded

src/test/regress/sql/errors.sql

+4-2
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,10 @@ NOT
366366
NULL);
367367

368368
-- Check that stack depth detection mechanism works and
369-
-- max_stack_depth is not set too high
369+
-- max_stack_depth is not set too high. The full error report is not
370+
-- very stable, so show only SQLSTATE and primary error message.
370371
create function infinite_recurse() returns int as
371372
'select infinite_recurse()' language sql;
372-
\set VERBOSITY terse
373+
\set VERBOSITY sqlstate
373374
select infinite_recurse();
375+
\echo :LAST_ERROR_MESSAGE

0 commit comments

Comments
 (0)