Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3c88199

Browse files
committed
Further stabilize output from rolenames regression test.
Commit e5209bf didn't quite get the job done, as I failed to notice that chksetconfig() also needed to have its ORDER BY extended. Per buildfarm member dory. Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2020-09-26%2020%3A10%3A13
1 parent e55f718 commit 3c88199

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/test/modules/unsafe_tests/expected/rolenames.out

+5-5
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ SELECT COALESCE(d.datname, 'ALL'), COALESCE(r.rolname, 'ALL'),
2929
AS v(uname, keyword)
3030
ON (r.rolname = v.uname)
3131
WHERE (r.rolname) IN ('Public', 'current_user', 'regress_testrol1', 'regress_testrol2')
32-
ORDER BY 1, 2;
32+
ORDER BY 1, 2, 3;
3333
$$ LANGUAGE SQL;
3434
CREATE FUNCTION chkumapping()
3535
RETURNS TABLE (umname name, umserver name, umoptions text[])
@@ -437,8 +437,8 @@ SELECT * FROM chksetconfig();
437437
ALL | Public | - | {application_name=BARBAR}
438438
ALL | current_user | - | {application_name=FOOFOO}
439439
ALL | regress_testrol1 | session_user | {application_name=BAR}
440-
ALL | regress_testrol2 | current_user | {application_name=FOO}
441440
ALL | regress_testrol2 | current_role | {application_name=FOO}
441+
ALL | regress_testrol2 | current_user | {application_name=FOO}
442442
(5 rows)
443443

444444
ALTER ROLE regress_testrol1 SET application_name to 'SLAM';
@@ -448,8 +448,8 @@ SELECT * FROM chksetconfig();
448448
ALL | Public | - | {application_name=BARBAR}
449449
ALL | current_user | - | {application_name=FOOFOO}
450450
ALL | regress_testrol1 | session_user | {application_name=SLAM}
451-
ALL | regress_testrol2 | current_user | {application_name=FOO}
452451
ALL | regress_testrol2 | current_role | {application_name=FOO}
452+
ALL | regress_testrol2 | current_user | {application_name=FOO}
453453
(5 rows)
454454

455455
ALTER ROLE CURRENT_ROLE RESET application_name;
@@ -489,8 +489,8 @@ SELECT * FROM chksetconfig();
489489
ALL | Public | - | {application_name=BARBAR}
490490
ALL | current_user | - | {application_name=FOOFOO}
491491
ALL | regress_testrol1 | session_user | {application_name=BAR}
492-
ALL | regress_testrol2 | current_user | {application_name=FOO}
493492
ALL | regress_testrol2 | current_role | {application_name=FOO}
493+
ALL | regress_testrol2 | current_user | {application_name=FOO}
494494
(5 rows)
495495

496496
ALTER USER regress_testrol1 SET application_name to 'SLAM';
@@ -500,8 +500,8 @@ SELECT * FROM chksetconfig();
500500
ALL | Public | - | {application_name=BARBAR}
501501
ALL | current_user | - | {application_name=FOOFOO}
502502
ALL | regress_testrol1 | session_user | {application_name=SLAM}
503-
ALL | regress_testrol2 | current_user | {application_name=FOO}
504503
ALL | regress_testrol2 | current_role | {application_name=FOO}
504+
ALL | regress_testrol2 | current_user | {application_name=FOO}
505505
(5 rows)
506506

507507
ALTER USER CURRENT_ROLE RESET application_name;

src/test/modules/unsafe_tests/sql/rolenames.sql

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ SELECT COALESCE(d.datname, 'ALL'), COALESCE(r.rolname, 'ALL'),
3030
AS v(uname, keyword)
3131
ON (r.rolname = v.uname)
3232
WHERE (r.rolname) IN ('Public', 'current_user', 'regress_testrol1', 'regress_testrol2')
33-
ORDER BY 1, 2;
33+
ORDER BY 1, 2, 3;
3434
$$ LANGUAGE SQL;
3535

3636
CREATE FUNCTION chkumapping()

0 commit comments

Comments
 (0)