Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3cb19f4

Browse files
author
Richard Guo
committed
Fix comment about cross-checking the varnullingrels
The nullingrels match checks are not limited to debugging builds. Oversight in commit 867be9c. Author: Richard Guo Reviewed-by: Alvaro Herrera, Tom Lane, Robert Haas Discussion: https://postgr.es/m/CAMbWs4_SDsdYD7DdQw7RXc3jv3axbg+RGZ7aSi9GaqX=F8hNVw@mail.gmail.com
1 parent e656657 commit 3cb19f4

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/backend/optimizer/plan/setrefs.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -2775,11 +2775,11 @@ build_tlist_index_other_vars(List *tlist, int ignore_rel)
27752775
* Also ensure that varnosyn is incremented by rtoffset.
27762776
* If no match, return NULL.
27772777
*
2778-
* In debugging builds, we cross-check the varnullingrels of the subplan
2779-
* output Var based on nrm_match. Most call sites should pass NRM_EQUAL
2780-
* indicating we expect an exact match. However, there are places where
2781-
* we haven't cleaned things up completely, and we have to settle for
2782-
* allowing subset or superset matches.
2778+
* We cross-check the varnullingrels of the subplan output Var based on
2779+
* nrm_match. Most call sites should pass NRM_EQUAL indicating we expect
2780+
* an exact match. However, there are places where we haven't cleaned
2781+
* things up completely, and we have to settle for allowing subset or
2782+
* superset matches.
27832783
*/
27842784
static Var *
27852785
search_indexed_tlist_for_var(Var *var, indexed_tlist *itlist,

0 commit comments

Comments
 (0)