Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3e514c1

Browse files
committed
Tweak description comments in tests for partition functions
The new wording is more generic and fixes one grammar mistake and one typo on the way. Per discussion between Amit Langote and me. Discussion: https://postgr.es/m/20181217064028.GJ31474@paquier.xyz
1 parent ed6f15e commit 3e514c1

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/test/regress/expected/partition_info.out

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--
2-
-- Tests for pg_partition_tree
2+
-- Tests for functions providing information about partitions
33
--
44
SELECT * FROM pg_partition_tree(NULL);
55
relid | parentrelid | isleaf | level
@@ -99,7 +99,7 @@ SELECT relid, parentrelid, level, isleaf
9999
(1 row)
100100

101101
DROP TABLE ptif_test;
102-
-- A table not part of a partition tree works is the only member listed.
102+
-- Table that is not part of any partition tree is the only member listed.
103103
CREATE TABLE ptif_normal_table(a int);
104104
SELECT relid, parentrelid, level, isleaf
105105
FROM pg_partition_tree('ptif_normal_table');
@@ -109,7 +109,9 @@ SELECT relid, parentrelid, level, isleaf
109109
(1 row)
110110

111111
DROP TABLE ptif_normal_table;
112-
-- Views and materialized viewS cannot be part of a partition tree.
112+
-- Various partitioning-related functions return NULL if passed relations
113+
-- of types that cannot be part of a partition tree; for example, views,
114+
-- materialized views, etc.
113115
CREATE VIEW ptif_test_view AS SELECT 1;
114116
CREATE MATERIALIZED VIEW ptif_test_matview AS SELECT 1;
115117
SELECT * FROM pg_partition_tree('ptif_test_view');

src/test/regress/sql/partition_info.sql

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--
2-
-- Tests for pg_partition_tree
2+
-- Tests for functions providing information about partitions
33
--
44
SELECT * FROM pg_partition_tree(NULL);
55
SELECT * FROM pg_partition_tree(0);
@@ -54,13 +54,15 @@ SELECT relid, parentrelid, level, isleaf
5454

5555
DROP TABLE ptif_test;
5656

57-
-- A table not part of a partition tree works is the only member listed.
57+
-- Table that is not part of any partition tree is the only member listed.
5858
CREATE TABLE ptif_normal_table(a int);
5959
SELECT relid, parentrelid, level, isleaf
6060
FROM pg_partition_tree('ptif_normal_table');
6161
DROP TABLE ptif_normal_table;
6262

63-
-- Views and materialized viewS cannot be part of a partition tree.
63+
-- Various partitioning-related functions return NULL if passed relations
64+
-- of types that cannot be part of a partition tree; for example, views,
65+
-- materialized views, etc.
6466
CREATE VIEW ptif_test_view AS SELECT 1;
6567
CREATE MATERIALIZED VIEW ptif_test_matview AS SELECT 1;
6668
SELECT * FROM pg_partition_tree('ptif_test_view');

0 commit comments

Comments
 (0)