Remove some useless free calls.

Amit Kapila · Amit Kapila · commit 3e67a5cac6a5 · 2022-03-25T07:37:06.000+05:30
These were introduced in recent commit 52e4f0c. We were trying to free some transient space consumption and that too was not entirely correct and complete. We don't need this partial freeing of memory as it will be allocated just once for a query and will be freed at the end of the query. Author: Zhihong Yu Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CALNJ-vQORfQ=vicbKA_RmeGZGzm1y3WsEcZqXWi7qjN43Cz_vg@mail.gmail.com
diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c
@@ -409,9 +409,6 @@ contain_invalid_rfcolumn(Oid pubid, Relation relation, List *ancestors,
 		context.bms_replident = bms;
 		rfnode = stringToNode(TextDatumGetCString(rfdatum));
 		result = contain_invalid_rfcolumn_walker(rfnode, &context);
-
-		bms_free(bms);
-		pfree(rfnode);
 	}
 
 	ReleaseSysCache(rftuple);
@@ -1182,9 +1179,6 @@ AlterPublicationTables(AlterPublicationStmt *stmt, HeapTuple tup,
 				}
 			}
 
-			if (oldrelwhereclause)
-				pfree(oldrelwhereclause);
-
 			/*
 			 * Add the non-matched relations to a list so that they can be
 			 * dropped.

Original file line number	Diff line number	Diff line change
`@@ -409,9 +409,6 @@ contain_invalid_rfcolumn(Oid pubid, Relation relation, List *ancestors,`
`409`	`409`	`context.bms_replident = bms;`
`410`	`410`	`rfnode = stringToNode(TextDatumGetCString(rfdatum));`
`411`	`411`	`result = contain_invalid_rfcolumn_walker(rfnode, &context);`
`412`		`-`
`413`		`- bms_free(bms);`
`414`		`- pfree(rfnode);`
`415`	`412`	`}`
`416`	`413`
`417`	`414`	`ReleaseSysCache(rftuple);`
`@@ -1182,9 +1179,6 @@ AlterPublicationTables(AlterPublicationStmt *stmt, HeapTuple tup,`
`1182`	`1179`	`}`
`1183`	`1180`	`}`
`1184`	`1181`
`1185`		`- if (oldrelwhereclause)`
`1186`		`- pfree(oldrelwhereclause);`
`1187`		`-`
`1188`	`1182`	`/*`
`1189`	`1183`	`* Add the non-matched relations to a list so that they can be`
`1190`	`1184`	`* dropped.`