Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3e8da50

Browse files
committed
Fix instability in regression test for Parallel Hash Full Join
As reported by buildfarm member conchuela, one of the regression tests added by 558c9d7 is having some ordering issues. This commit adds an ORDER BY clause to make the output more stable for the problematic query. Fix suggested by Tom Lane. The plan of the query updated still uses a parallel hash full join. Author: Melanie Plageman Discussion: https://postgr.es/m/623596.1684541098@sss.pgh.pa.us
1 parent d522b05 commit 3e8da50

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/test/regress/expected/join_hash.out

+2-1
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,8 @@ INSERT INTO hjtest_matchbits_t2 VALUES (2);
971971
-- Update should create a HOT tuple. If this status bit isn't cleared, we won't
972972
-- correctly emit the NULL-extended unmatching tuple in full hash join.
973973
UPDATE hjtest_matchbits_t2 set id = 2;
974-
SELECT * FROM hjtest_matchbits_t1 t1 FULL JOIN hjtest_matchbits_t2 t2 ON t1.id = t2.id;
974+
SELECT * FROM hjtest_matchbits_t1 t1 FULL JOIN hjtest_matchbits_t2 t2 ON t1.id = t2.id
975+
ORDER BY t1.id;
975976
id | id
976977
----+----
977978
1 |

src/test/regress/sql/join_hash.sql

+2-1
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,8 @@ INSERT INTO hjtest_matchbits_t2 VALUES (2);
523523
-- Update should create a HOT tuple. If this status bit isn't cleared, we won't
524524
-- correctly emit the NULL-extended unmatching tuple in full hash join.
525525
UPDATE hjtest_matchbits_t2 set id = 2;
526-
SELECT * FROM hjtest_matchbits_t1 t1 FULL JOIN hjtest_matchbits_t2 t2 ON t1.id = t2.id;
526+
SELECT * FROM hjtest_matchbits_t1 t1 FULL JOIN hjtest_matchbits_t2 t2 ON t1.id = t2.id
527+
ORDER BY t1.id;
527528
-- Test serial full hash join.
528529
-- Resetting parallel_setup_cost should force a serial plan.
529530
-- Just to be safe, however, set enable_parallel_hash to off, as parallel full

0 commit comments

Comments
 (0)