Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3efc82e

Browse files
committed
Disable debug_discard_caches in test_oat_hooks test.
The test output varies when debug_discard_caches is enabled, because that causes extra executions of recomputeNamespacePath. Maybe putting a hook in that was a bad idea, but as a stopgap, just turn off debug_discard_caches in this test. Per buildfarm (now that we have debug_discard_caches coverage again). Back-patch to v15 where this module was added. Discussion: https://postgr.es/m/2267406.1668804934@sss.pgh.pa.us
1 parent 3b8ad00 commit 3efc82e

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/test/modules/test_oat_hooks/expected/test_oat_hooks.out

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
-- This test script fails if debug_discard_caches is enabled, because cache
2+
-- flushes cause extra calls of the OAT hook in recomputeNamespacePath,
3+
-- resulting in more NOTICE messages than are in the expected output.
4+
SET debug_discard_caches = 0;
15
-- Creating privileges on a placeholder GUC should create entries in the
26
-- pg_parameter_acl catalog which conservatively grant no privileges to public.
37
CREATE ROLE regress_role_joe;

src/test/modules/test_oat_hooks/sql/test_oat_hooks.sql

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
-- This test script fails if debug_discard_caches is enabled, because cache
2+
-- flushes cause extra calls of the OAT hook in recomputeNamespacePath,
3+
-- resulting in more NOTICE messages than are in the expected output.
4+
SET debug_discard_caches = 0;
5+
16
-- Creating privileges on a placeholder GUC should create entries in the
27
-- pg_parameter_acl catalog which conservatively grant no privileges to public.
38
CREATE ROLE regress_role_joe;

0 commit comments

Comments
 (0)