Add comment for getpwid() safety.

bmomjian · bmomjian · commit 3f0f30d1a166 · 2001-01-24T05:24:43.000Z
diff --git a/src/backend/main/main.c b/src/backend/main/main.c
@@ -13,7 +13,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/main/main.c,v 1.38 2001/01/24 03:50:06 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/main/main.c,v 1.39 2001/01/24 05:24:43 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -159,6 +159,7 @@ main(int argc, char *argv[])
 		fprintf(stderr, "%s: invalid current euid", argv[0]);
 		exit(1);
 	}
+	/* Allocate new memory because later getpwuid() calls can overwrite it */
 	pw_name_persist = strdup(pw->pw_name);
 
 	exit(PostgresMain(argc, argv, argc, argv, pw_name_persist));

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`*`
`14`	`14`	`*`
`15`	`15`	`* IDENTIFICATION`
`16`		`- * $Header: /cvsroot/pgsql/src/backend/main/main.c,v 1.38 2001/01/24 03:50:06 momjian Exp $`
	`16`	`+ * $Header: /cvsroot/pgsql/src/backend/main/main.c,v 1.39 2001/01/24 05:24:43 momjian Exp $`
`17`	`17`	`*`
`18`	`18`	`*-------------------------------------------------------------------------`
`19`	`19`	`*/`
`@@ -159,6 +159,7 @@ main(int argc, char *argv[])`
`159`	`159`	`fprintf(stderr, "%s: invalid current euid", argv[0]);`
`160`	`160`	`exit(1);`
`161`	`161`	`}`
	`162`	`+ /* Allocate new memory because later getpwuid() calls can overwrite it */`
`162`	`163`	`pw_name_persist = strdup(pw->pw_name);`
`163`	`164`
`164`	`165`	`exit(PostgresMain(argc, argv, argc, argv, pw_name_persist));`