Fix thinko in encoding check for chr()

adunstan · adunstan · commit 3f2b1db240f2 · 2007-12-18T18:01:48.000Z
diff --git a/src/backend/utils/adt/oracle_compat.c b/src/backend/utils/adt/oracle_compat.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	$PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.75 2007/11/24 21:16:55 tgl Exp $
+ *	$PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.76 2007/12/18 18:01:48 adunstan Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1423,7 +1423,7 @@ chr			(PG_FUNCTION_ARGS)
 
 		is_mb = pg_encoding_max_length(encoding) > 1;
 
-		if ((is_mb && (cvalue > 255)) || (!is_mb && (cvalue > 127)))
+		if ((is_mb && (cvalue > 127)) || (!is_mb && (cvalue > 255)))
 			ereport(ERROR,
 					(errcode(ERRCODE_PROGRAM_LIMIT_EXCEEDED),
 					 errmsg("requested character too large for encoding: %d",

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.75 2007/11/24 21:16:55 tgl Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.76 2007/12/18 18:01:48 adunstan Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -1423,7 +1423,7 @@ chr (PG_FUNCTION_ARGS)`
`1423`	`1423`
`1424`	`1424`	`is_mb = pg_encoding_max_length(encoding) > 1;`
`1425`	`1425`
`1426`		`- if ((is_mb && (cvalue > 255)) \|\| (!is_mb && (cvalue > 127)))`
	`1426`	`+ if ((is_mb && (cvalue > 127)) \|\| (!is_mb && (cvalue > 255)))`
`1427`	`1427`	`ereport(ERROR,`
`1428`	`1428`	`(errcode(ERRCODE_PROGRAM_LIMIT_EXCEEDED),`
`1429`	`1429`	`errmsg("requested character too large for encoding: %d",`