Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 3f8072b

Browse files
committed
Disallow SSL renegotiation
SSL renegotiation is already disabled as of 48d23c7, however this does not prevent the server to comply with a client willing to use renegotiation. In the last couple of years, renegotiation had its set of security issues and flaws (like the recent CVE-2021-3449), and it could be possible to crash the backend with a client attempting renegotiation. This commit takes one extra step by disabling renegotiation in the backend in the same way as SSL compression (f9264d1) or tickets (97d3a0b). OpenSSL 1.1.0h has added an option named SSL_OP_NO_RENEGOTIATION able to achieve that. In older versions there is an option called SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS that was undocumented, and could be set within the SSL object created when the TLS connection opens, but I have decided not to use it, as it feels trickier to rely on, and it is not official. Note that this option is not usable in OpenSSL < 1.1.0h as the internal contents of the *SSL object are hidden to applications. SSL renegotiation concerns protocols up to TLSv1.2. Per original report from Robert Haas, with a patch based on a suggestion by Andres Freund. Author: Michael Paquier Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/YKZBXx7RhU74FlTE@paquier.xyz Backpatch-through: 9.6
1 parent 61feb86 commit 3f8072b

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

src/backend/libpq/be-secure-openssl.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,16 @@ be_tls_init(bool isServerStart)
233233
/* disallow SSL session caching, too */
234234
SSL_CTX_set_session_cache_mode(context, SSL_SESS_CACHE_OFF);
235235

236+
#ifdef SSL_OP_NO_RENEGOTIATION
237+
238+
/*
239+
* Disallow SSL renegotiation, option available since 1.1.0h. This
240+
* concerns only TLSv1.2 and older protocol versions, as TLSv1.3 has no
241+
* support for renegotiation.
242+
*/
243+
SSL_CTX_set_options(context, SSL_OP_NO_RENEGOTIATION);
244+
#endif
245+
236246
/* set up ephemeral DH and ECDH keys */
237247
if (!initialize_dh(context, isServerStart))
238248
goto error;

0 commit comments

Comments
 (0)