Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 4036bcb

Browse files
author
Etsuro Fujita
committed
postgres_fdw: Update comments in make_new_connection().
Expand the comment about the parallel_commit option to mention that the default is false. Also, since the comment about alteration of the keep_connections option, which was located above the expanded comment, holds true for the parallel_commit option, rewrite it to reflect this, and move it to after the expanded comment. Follow-up for commit 04e706d. Discussion: https://postgr.es/m/CAPmGK16Kg2Bf90sqzcZ4YM5cN_G-4h7wFUS01qQpqNB%2B2BG5_w%40mail.gmail.com
1 parent 5edeb57 commit 4036bcb

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

contrib/postgres_fdw/connection.c

+6-5
Original file line numberDiff line numberDiff line change
@@ -318,14 +318,15 @@ make_new_connection(ConnCacheEntry *entry, UserMapping *user)
318318
* open even after the transaction using it ends, so that the subsequent
319319
* transactions can re-use it.
320320
*
321-
* It's enough to determine this only when making new connection because
322-
* all the connections to the foreign server whose keep_connections option
323-
* is changed will be closed and re-made later.
324-
*
325321
* By default, all the connections to any foreign servers are kept open.
326322
*
327323
* Also determine whether to commit (sub)transactions opened on the remote
328-
* server in parallel at (sub)transaction end.
324+
* server in parallel at (sub)transaction end, which is disabled by
325+
* default.
326+
*
327+
* Note: it's enough to determine these only when making a new connection
328+
* because these settings for it are changed, it will be closed and
329+
* re-made later.
329330
*/
330331
entry->keep_connections = true;
331332
entry->parallel_commit = false;

0 commit comments

Comments
 (0)