Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 40d5e59

Browse files
committed
Fix 003_check_guc.pl when loading modules with custom GUCs
The test missed that custom GUCs need to be ignored from the list of parameters that can exist in postgresql.conf.sample. This caused the test to fail on a server where such a module is loaded, when using EXTRA_INSTALL and TEMP_CONFIG, for instance. Author: Anton A. Melnikov Discussion: https://postgr.es/m/fc5509ce-5144-4dac-8d13-21793da44fc5@postgrespro.ru Backpatch-through: 15
1 parent cac169d commit 40d5e59

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/test/modules/test_misc/t/003_check_guc.pl

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,13 @@
1414
# Grab the names of all the parameters that can be listed in the
1515
# configuration sample file. config_file is an exception, it is not
1616
# in postgresql.conf.sample but is part of the lists from guc_tables.c.
17+
# Custom GUCs loaded by extensions are excluded.
1718
my $all_params = $node->safe_psql(
1819
'postgres',
1920
"SELECT name
2021
FROM pg_settings
2122
WHERE NOT 'NOT_IN_SAMPLE' = ANY (pg_settings_get_flags(name)) AND
22-
name <> 'config_file'
23+
name <> 'config_file' AND category <> 'Customized Options'
2324
ORDER BY 1");
2425
# Note the lower-case conversion, for consistency.
2526
my @all_params_array = split("\n", lc($all_params));

0 commit comments

Comments
 (0)