ICU: fix pg_upgrade for Windows

In Postgres Pro version 9.6 and below, if:
- the maximum length of the database encoding is greater that 1
- and the database locale for collations contains language or country strings
(e.g. "Russian_Russia[.encoding]" or "English_United States[.encoding]")
ICU used the root locale for the default collations. So invalidate indexes and
check constraints that use the database default collation.

P.S. Perhaps it would be safer to rename the database locale for collations in
pg_database, but we could not find the same libc locale for the ICU root locale
:(

Author: Marina Polyakova

src/bin/pg_upgrade/check.c

@@ -135,8 +135,8 @@ check_and_dump_old_cluster(bool live_check)
 	if (old_cluster.edition != PG_ORIGINAL &&
 			GET_MAJOR_VERSION(old_cluster.major_version) <= 906)
 	{
-		old_9_6_pgpro_invalidate_secondary_collation_indexes(&old_cluster, true);
-		old_9_6_pgpro_invalidate_secondary_collation_constraints(&old_cluster, true);
+		old_9_6_pgpro_invalidate_collation_indexes(&old_cluster, true);
+		old_9_6_pgpro_invalidate_collation_constraints(&old_cluster, true);
 	}
 
 	/*
@@ -209,8 +209,8 @@ issue_warnings_and_set_wal_level(void)
 	if (old_cluster.edition != PG_ORIGINAL &&
 			GET_MAJOR_VERSION(old_cluster.major_version) <= 906)
 	{
-		old_9_6_pgpro_invalidate_secondary_collation_indexes(&new_cluster, false);
-		old_9_6_pgpro_invalidate_secondary_collation_constraints(&new_cluster, false);
+		old_9_6_pgpro_invalidate_collation_indexes(&new_cluster, false);
+		old_9_6_pgpro_invalidate_collation_constraints(&new_cluster, false);
 	}
 
 	stop_postmaster(false);

src/bin/pg_upgrade/pg_upgrade.h

@@ -450,9 +450,9 @@ void		old_9_3_check_for_line_data_type_usage(ClusterInfo *cluster);
 void		old_9_6_check_for_unknown_data_type_usage(ClusterInfo *cluster);
 void old_9_6_invalidate_hash_indexes(ClusterInfo *cluster,
 								bool check_mode);
-void old_9_6_pgpro_invalidate_secondary_collation_indexes(ClusterInfo *cluster,
+void old_9_6_pgpro_invalidate_collation_indexes(ClusterInfo *cluster,
 								bool check_mode);
-void old_9_6_pgpro_invalidate_secondary_collation_constraints(ClusterInfo *cluster, bool check_mode);
+void old_9_6_pgpro_invalidate_collation_constraints(ClusterInfo *cluster, bool check_mode);
 
 /* parallel.c */
 void parallel_exec_prog(const char *log_file, const char *opt_log_file,