Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 44cbba9

Browse files
committed
Adjust EXPLAIN test case to filter out "Actual Rows" values.
Per the buildfarm, these tests appear to be unstable in the wake of commit ddb17e3. I'm not sure that just hiding this output is the right way forward, because I think there may be other test cases that will fail with lower probability even after this fix. However, it's hard to tell right now, because this is failing on a number of buildfarm animals. So let's try this for now to either get a clearer picture of what else is broken, or as a stopgap until we decide what the permanent fix should be, or perhaps this will be the permanent fix after all.
1 parent 98fc31d commit 44cbba9

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/test/regress/expected/explain.out

+3-2
Original file line numberDiff line numberDiff line change
@@ -493,6 +493,9 @@ select jsonb_pretty(
493493
-- Also remove its sort-type fields, as those aren't 100% stable
494494
#- '{0,Plan,Plans,0,Sort Method}'
495495
#- '{0,Plan,Plans,0,Sort Space Type}'
496+
-- Actual Rows can be 0 or 0.0 depending on whether loops>1
497+
#- '{0,Plan,Plans,0,Actual Rows}'
498+
#- '{0,Plan,Plans,0,Plans,0,Actual Rows}'
496499
);
497500
jsonb_pretty
498501
-------------------------------------------------------------
@@ -528,7 +531,6 @@ select jsonb_pretty(
528531
"Plan Rows": 0, +
529532
"Plan Width": 0, +
530533
"Total Cost": 0.0, +
531-
"Actual Rows": 0.0, +
532534
"Actual Loops": 0, +
533535
"Startup Cost": 0.0, +
534536
"Async Capable": false, +
@@ -575,7 +577,6 @@ select jsonb_pretty(
575577
"Plan Rows": 0, +
576578
"Plan Width": 0, +
577579
"Total Cost": 0.0, +
578-
"Actual Rows": 0.0, +
579580
"Actual Loops": 0, +
580581
"Startup Cost": 0.0, +
581582
"Async Capable": false, +

src/test/regress/sql/explain.sql

+3
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,9 @@ select jsonb_pretty(
147147
-- Also remove its sort-type fields, as those aren't 100% stable
148148
#- '{0,Plan,Plans,0,Sort Method}'
149149
#- '{0,Plan,Plans,0,Sort Space Type}'
150+
-- Actual Rows can be 0 or 0.0 depending on whether loops>1
151+
#- '{0,Plan,Plans,0,Actual Rows}'
152+
#- '{0,Plan,Plans,0,Plans,0,Actual Rows}'
150153
);
151154

152155
rollback;

0 commit comments

Comments
 (0)