Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 466368b

Browse files
committed
Detect and error out on inability to get proper linkage information required for plperl, usually due to absence of perl ExtUtils::Embed module. Backpatch as far as 8.1.
1 parent bd059c2 commit 466368b

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

config/perl.m4

+10-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# $PostgreSQL: pgsql/config/perl.m4,v 1.3 2003/11/29 19:51:17 pgsql Exp $
1+
# $PostgreSQL: pgsql/config/perl.m4,v 1.4 2008/11/12 00:00:05 adunstan Exp $
22

33

44
# PGAC_PATH_PERL
@@ -32,4 +32,12 @@ pgac_tmp1=`$PERL -MExtUtils::Embed -e ldopts`
3232
pgac_tmp2=`$PERL -MConfig -e 'print $Config{ccdlflags}'`
3333
perl_embed_ldflags=`echo X"$pgac_tmp1" | sed "s/^X//;s%$pgac_tmp2%%"`
3434
AC_SUBST(perl_embed_ldflags)dnl
35-
AC_MSG_RESULT([$perl_embed_ldflags])])
35+
if test -z "$perl_embed_ldflags" ; then
36+
AC_MSG_RESULT(no)
37+
AC_MSG_ERROR([could not determine flags for linking embedded Perl.
38+
This probably means that ExtUtils::Embed or ExtUtils::MakeMaker is not
39+
installed.])
40+
else
41+
AC_MSG_RESULT([$perl_embed_ldflags])
42+
fi
43+
])# PGAC_CHECK_PERL_EMBED_LDFLAGS

configure

+14-1
Original file line numberDiff line numberDiff line change
@@ -6420,10 +6420,23 @@ echo $ECHO_N "checking for flags to link embedded Perl... $ECHO_C" >&6; }
64206420
pgac_tmp1=`$PERL -MExtUtils::Embed -e ldopts`
64216421
pgac_tmp2=`$PERL -MConfig -e 'print $Config{ccdlflags}'`
64226422
perl_embed_ldflags=`echo X"$pgac_tmp1" | sed "s/^X//;s%$pgac_tmp2%%"`
6423-
{ echo "$as_me:$LINENO: result: $perl_embed_ldflags" >&5
6423+
if test -z "$perl_embed_ldflags" ; then
6424+
{ echo "$as_me:$LINENO: result: no" >&5
6425+
echo "${ECHO_T}no" >&6; }
6426+
{ { echo "$as_me:$LINENO: error: could not determine flags for linking embedded Perl.
6427+
This probably means that ExtUtils::Embed or ExtUtils::MakeMaker is not
6428+
installed." >&5
6429+
echo "$as_me: error: could not determine flags for linking embedded Perl.
6430+
This probably means that ExtUtils::Embed or ExtUtils::MakeMaker is not
6431+
installed." >&2;}
6432+
{ (exit 1); exit 1; }; }
6433+
else
6434+
{ echo "$as_me:$LINENO: result: $perl_embed_ldflags" >&5
64246435
echo "${ECHO_T}$perl_embed_ldflags" >&6; }
64256436
fi
64266437

6438+
fi
6439+
64276440
if test "$with_python" = yes; then
64286441
# Extract the first word of "python", so it can be a program name with args.
64296442
set dummy python; ac_word=$2

0 commit comments

Comments
 (0)