Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 491bb81

Browse files
committed
Clarify some comments about ntstatus.h in win32_port.h
Some comments in this file referred to outdated links. This simplifies the outdated comment blocks and refreshes the links. Reported-by: Vignesh C Author: Juan José Santamaría Flecha Discussion: https://postgr.es/m/46C03E17-16F7-4C38-B148-029AC7448E96@gmail.com
1 parent 55ba564 commit 491bb81

File tree

1 file changed

+8
-17
lines changed

1 file changed

+8
-17
lines changed

src/include/port/win32_port.h

+8-17
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,11 @@
103103
* For WIN32, there is no wait() call so there are no wait() macros
104104
* to interpret the return value of system(). Instead, system()
105105
* return values < 0x100 are used for exit() termination, and higher
106-
* values are used to indicated non-exit() termination, which is
106+
* values are used to indicate non-exit() termination, which is
107107
* similar to a unix-style signal exit (think SIGSEGV ==
108108
* STATUS_ACCESS_VIOLATION). Return values are broken up into groups:
109109
*
110-
* http://msdn2.microsoft.com/en-gb/library/aa489609.aspx
110+
* https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/using-ntstatus-values
111111
*
112112
* NT_SUCCESS 0 - 0x3FFFFFFF
113113
* NT_INFORMATION 0x40000000 - 0x7FFFFFFF
@@ -121,22 +121,13 @@
121121
*
122122
* Wine (URL used in our error messages) -
123123
* http://source.winehq.org/source/include/ntstatus.h
124-
* Descriptions - http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt
125-
* MS SDK - http://www.nologs.com/ntstatus.html
124+
* Descriptions -
125+
* https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55
126126
*
127-
* It seems the exception lists are in both ntstatus.h and winnt.h, but
128-
* ntstatus.h has a more comprehensive list, and it only contains
129-
* exception values, rather than winnt, which contains lots of other
130-
* things:
131-
*
132-
* http://www.microsoft.com/msj/0197/exception/exception.aspx
133-
*
134-
* The ExceptionCode parameter is the number that the operating system
135-
* assigned to the exception. You can see a list of various exception codes
136-
* in WINNT.H by searching for #defines that start with "STATUS_". For
137-
* example, the code for the all-too-familiar STATUS_ACCESS_VIOLATION is
138-
* 0xC0000005. A more complete set of exception codes can be found in
139-
* NTSTATUS.H from the Windows NT DDK.
127+
* The comprehensive exception list is included in ntstatus.h from the
128+
* Windows Driver Kit (WDK). A subset of the list is also included in
129+
* winnt.h from the Windows SDK. Defining WIN32_NO_STATUS before including
130+
* windows.h helps to avoid any conflicts.
140131
*
141132
* Some day we might want to print descriptions for the most common
142133
* exceptions, rather than printing an include file name. We could use

0 commit comments

Comments
 (0)