Remove extra MarkBufferDirty().

Author: Alexander Korotkov

src/backend/access/heap/heapam.c

@@ -2688,6 +2688,8 @@ heap_page_shift_base(Relation relation, Buffer buffer, Page page, bool multi, in
 	OffsetNumber		offnum,
 						maxoff;
 
+	START_CRIT_SECTION();
+
 	/* Iterate over page items */
 	maxoff = PageGetMaxOffsetNumber(page);
 	for (offnum = FirstOffsetNumber;
@@ -2762,6 +2764,8 @@ heap_page_shift_base(Relation relation, Buffer buffer, Page page, bool multi, in
 
 		PageSetLSN(page, recptr);
 	}
+
+	END_CRIT_SECTION();
 }
 
 /*
@@ -2909,7 +2913,6 @@ heap_page_prepare_for_xid(Relation relation, Buffer buffer,
 			Assert(xid <= base + delta + MaxShortTransactionId);
 
 			heap_page_shift_base(relation, buffer, page, multi, delta);
-			MarkBufferDirty(buffer);
 
 			base = multi ? pageSpecial->pd_multi_base : pageSpecial->pd_xid_base;
 			Assert(xid >= base + FirstNormalTransactionId);
@@ -2931,7 +2934,6 @@ heap_page_prepare_for_xid(Relation relation, Buffer buffer,
 				Assert(xid <= base + delta + MaxShortTransactionId);
 
 				heap_page_shift_base(relation, buffer, page, multi, delta);
-				MarkBufferDirty(buffer);
 
 				base = multi ? pageSpecial->pd_multi_base : pageSpecial->pd_xid_base;
 				Assert(xid >= base + FirstNormalTransactionId);
@@ -2954,7 +2956,6 @@ heap_page_prepare_for_xid(Relation relation, Buffer buffer,
 				Assert(xid <= base + delta + MaxShortTransactionId);
 
 				heap_page_shift_base(relation, buffer, page, multi, delta);
-				MarkBufferDirty(buffer);
 
 				base = multi ? pageSpecial->pd_multi_base : pageSpecial->pd_xid_base;
 				Assert(xid >= base + FirstNormalTransactionId);