Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 4b885d0

Browse files
committed
Remove the flaky check in event_trigger_login regression test
The query checks that pg_database.dathasloginevt is unset on connect when there are no event triggers. However, unsetting this flag is implemented in a non-blocking way, so a concurrent autovacuum connection breaks this check. It doesn't seem we can do much with this, at least within a regression test. So, remove it. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/44807d19-81a6-3884-3e0f-22dd99aac3ed%40gmail.com
1 parent 58fbbc9 commit 4b885d0

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

src/test/regress/expected/event_trigger_login.out

-6
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,3 @@ DROP TABLE user_logins;
3737
DROP EVENT TRIGGER on_login_trigger;
3838
DROP FUNCTION on_login_proc();
3939
\c
40-
SELECT dathasloginevt FROM pg_database WHERE datname= :'DBNAME';
41-
dathasloginevt
42-
----------------
43-
f
44-
(1 row)
45-

src/test/regress/sql/event_trigger_login.sql

-1
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,3 @@ DROP TABLE user_logins;
2222
DROP EVENT TRIGGER on_login_trigger;
2323
DROP FUNCTION on_login_proc();
2424
\c
25-
SELECT dathasloginevt FROM pg_database WHERE datname= :'DBNAME';

0 commit comments

Comments
 (0)