Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 4c68883

Browse files
committed
Fix minor bug in isolationtester.
If the lock wait query failed, isolationtester would report the PQerrorMessage from some other connection, meaning there would be no message or an unrelated one. This seems like a pretty unlikely occurrence, but if it did happen, this bug could make it really difficult/confusing to figure out what happened. That seems to justify patching all the way back. In passing, clean up another place where the "wrong" conn was used for an error report. That one's not actually buggy because it's a different alias for the same connection, but it's still confusing to the reader.
1 parent 1164389 commit 4c68883

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/test/isolation/isolationtester.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ run_permutation(TestSpec *testspec, int nsteps, Step **steps)
596596
if (!PQsendQuery(conn, step->sql))
597597
{
598598
fprintf(stdout, "failed to send query for step %s: %s\n",
599-
step->name, PQerrorMessage(conns[1 + step->session]));
599+
step->name, PQerrorMessage(conn));
600600
exit_nicely();
601601
}
602602

@@ -745,7 +745,7 @@ try_complete_step(Step *step, int flags)
745745
PQntuples(res) != 1)
746746
{
747747
fprintf(stderr, "lock wait query failed: %s",
748-
PQerrorMessage(conn));
748+
PQerrorMessage(conns[0]));
749749
exit_nicely();
750750
}
751751
waiting = ((PQgetvalue(res, 0, 0))[0] == 't');

0 commit comments

Comments
 (0)