Do _bt_wrtbuf() outside critical section, per discussion with Vadim 1/19.

tglsfdc · tglsfdc · commit 4e27b308e2bf · 2001-01-23T23:29:22.000Z
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.74 2001/01/14 05:08:14 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.75 2001/01/23 23:29:22 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -861,10 +861,11 @@ _bt_split(Relation rel, Buffer buf, OffsetNumber firstright,
 
 	PageRestoreTempPage(leftpage, origpage);
 
+	END_CRIT_SECTION();
+
 	/* write and release the old right sibling */
 	if (!P_RIGHTMOST(ropaque))
 		_bt_wrtbuf(rel, sbuf);
-	END_CRIT_SECTION();
 
 	/* split's done */
 	return rbuf;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.74 2001/01/14 05:08:14 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.75 2001/01/23 23:29:22 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -861,10 +861,11 @@ _bt_split(Relation rel, Buffer buf, OffsetNumber firstright,`
`861`	`861`
`862`	`862`	`PageRestoreTempPage(leftpage, origpage);`
`863`	`863`
	`864`	`+ END_CRIT_SECTION();`
	`865`	`+`
`864`	`866`	`/* write and release the old right sibling */`
`865`	`867`	`if (!P_RIGHTMOST(ropaque))`
`866`	`868`	`_bt_wrtbuf(rel, sbuf);`
`867`		`- END_CRIT_SECTION();`
`868`	`869`
`869`	`870`	`/* split's done */`
`870`	`871`	`return rbuf;`