Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 4f49b3f

Browse files
committed
Trust signalfd on illumos, again.
Commit 3ab4fc5 avoided choosing signalfd by default on illumos, because it triggered kernel panics. That was fixed, so we can remove a kludge from our code. Users/packagers can still override the default choice at compile time if desired, and we'll leave the back-branches unchanged so they keep choosing self-pipe by default, but we'll default to signalfd (like we do for Linux) in 17. Fixed kernels should be everywhere by the time 17 ships. The illumos issues were: * https://www.illumos.org/issues/13700 * https://www.illumos.org/issues/14892 Discussion: https://postgr.es/m/CA+hUKG+NK-K_G_i1H3OpDTwYPEsiwQi_jw58PGcW2H+-N2eVCA@mail.gmail.com
1 parent 01d56ee commit 4f49b3f

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/backend/storage/ipc/latch.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,12 @@
8686

8787
/*
8888
* By default, we use a self-pipe with poll() and a signalfd with epoll(), if
89-
* available. We avoid signalfd on illumos for now based on problem reports.
90-
* For testing the choice can also be manually specified.
89+
* available. For testing the choice can also be manually specified.
9190
*/
9291
#if defined(WAIT_USE_POLL) || defined(WAIT_USE_EPOLL)
9392
#if defined(WAIT_USE_SELF_PIPE) || defined(WAIT_USE_SIGNALFD)
9493
/* don't overwrite manual choice */
95-
#elif defined(WAIT_USE_EPOLL) && defined(HAVE_SYS_SIGNALFD_H) && \
96-
!defined(__illumos__)
94+
#elif defined(WAIT_USE_EPOLL) && defined(HAVE_SYS_SIGNALFD_H)
9795
#define WAIT_USE_SIGNALFD
9896
#else
9997
#define WAIT_USE_SELF_PIPE

0 commit comments

Comments
 (0)