Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 5136967

Browse files
committed
Fix timing issue in deadlock recovery conflict test.
Per buildfarm members longfin and skink. Discussion: https://postgr.es/m/20220413002626.udl7lll7f3o7nre7@alap3.anarazel.de Backpatch: 10-
1 parent f74496d commit 5136967

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

src/test/recovery/t/031_recovery_conflict.pl

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,14 @@
231231
$sect = "startup deadlock";
232232
$expected_conflicts++;
233233

234+
# Want to test recovery deadlock conflicts, not buffer pin conflicts. Without
235+
# changing max_standby_streaming_delay it'd be timing dependent what we hit
236+
# first
237+
$node_standby->adjust_conf('postgresql.conf', 'max_standby_streaming_delay',
238+
"${PostgreSQL::Test::Utils::timeout_default}s");
239+
$node_standby->restart();
240+
reconnect_and_clear();
241+
234242
# Generate a few dead rows, to later be cleaned up by vacuum. Then acquire a
235243
# lock on another relation in a prepared xact, so it's held continuously by
236244
# the startup process. The standby psql will block acquiring that lock while
@@ -286,6 +294,9 @@
286294

287295
# clean up for next tests
288296
$node_primary->safe_psql($test_db, qq[ROLLBACK PREPARED 'lock';]);
297+
$node_standby->adjust_conf('postgresql.conf', 'max_standby_streaming_delay', '50ms');
298+
$node_standby->restart();
299+
reconnect_and_clear();
289300

290301

291302
# Check that expected number of conflicts show in pg_stat_database. Needs to

0 commit comments

Comments
 (0)