Added missing SPI_finish() calls to get_tuple_of_interest(). Fixes bug

jconway · jconway · commit 5392e73b6c92 · 2003-11-26T20:43:25.000Z
reported by Andrea Grassi.
diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
@@ -1766,6 +1766,7 @@ get_tuple_of_interest(Oid relid, int16 *pkattnums, int16 pknumatts, char **src_p
 		SPITupleTable *tuptable = SPI_tuptable;
 
 		tuple = SPI_copytuple(tuptable->vals[0]);
+		SPI_finish();
 
 		return tuple;
 	}
@@ -1774,6 +1775,8 @@ get_tuple_of_interest(Oid relid, int16 *pkattnums, int16 pknumatts, char **src_p
 		/*
 		 * no qualifying tuples
 		 */
+		SPI_finish();
+
 		return NULL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1766,6 +1766,7 @@ get_tuple_of_interest(Oid relid, int16 pkattnums, int16 pknumatts, char *src_p`
`1766`	`1766`	`SPITupleTable *tuptable = SPI_tuptable;`
`1767`	`1767`
`1768`	`1768`	`tuple = SPI_copytuple(tuptable->vals[0]);`
	`1769`	`+ SPI_finish();`
`1769`	`1770`
`1770`	`1771`	`return tuple;`
`1771`	`1772`	`}`
`@@ -1774,6 +1775,8 @@ get_tuple_of_interest(Oid relid, int16 pkattnums, int16 pknumatts, char *src_p`
`1774`	`1775`	`/*`
`1775`	`1776`	`* no qualifying tuples`
`1776`	`1777`	`*/`
	`1778`	`+ SPI_finish();`
	`1779`	`+`
`1777`	`1780`	`return NULL;`
`1778`	`1781`	`}`
`1779`	`1782`