Fix precedence problem in new Perl code.

tglsfdc · tglsfdc · commit 59cb323053f4 · 2018-05-04T09:46:35.000-04:00
I think this bit of commit 1f1cd9b didn't do quite what I meant :-(
diff --git a/src/backend/catalog/Catalog.pm b/src/backend/catalog/Catalog.pm
@@ -356,7 +356,7 @@ sub RenameTempFile
 	if (-f $final_name
 		&& compare($temp_name, $final_name) == 0)
 	{
-		unlink $temp_name || die "unlink: $temp_name: $!";
+		unlink($temp_name) || die "unlink: $temp_name: $!";
 	}
 	else
 	{

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,7 @@ sub RenameTempFile`
`356`	`356`	`if (-f $final_name`
`357`	`357`	`&& compare($temp_name, $final_name) == 0)`
`358`	`358`	`{`
`359`		`- unlink $temp_name \|\| die "unlink: $temp_name: $!";`
	`359`	`+ unlink($temp_name) \|\| die "unlink: $temp_name: $!";`
`360`	`360`	`}`
`361`	`361`	`else`
`362`	`362`	`{`