Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 5a90740

Browse files
committed
Update HINT for pre-existing shared memory block.
One should almost always terminate an old process, not use a manual removal tool like ipcrm. Removal of the ipcclean script eleven years ago (39627b1) and its non-replacement corroborate that manual shm removal is now a niche goal. Back-patch to 9.4 (all supported versions). Reviewed by Daniel Gustafsson and Kyotaro HORIGUCHI. Discussion: https://postgr.es/m/20180812064815.GB2301738@rfd.leadboat.com
1 parent bfbcad4 commit 5a90740

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/backend/utils/init/miscinit.c

+3-7
Original file line numberDiff line numberDiff line change
@@ -1066,14 +1066,10 @@ CreateLockFile(const char *filename, bool amPostmaster,
10661066
if (PGSharedMemoryIsInUse(id1, id2))
10671067
ereport(FATAL,
10681068
(errcode(ERRCODE_LOCK_FILE_EXISTS),
1069-
errmsg("pre-existing shared memory block "
1070-
"(key %lu, ID %lu) is still in use",
1069+
errmsg("pre-existing shared memory block (key %lu, ID %lu) is still in use",
10711070
id1, id2),
1072-
errhint("If you're sure there are no old "
1073-
"server processes still running, remove "
1074-
"the shared memory block "
1075-
"or just delete the file \"%s\".",
1076-
filename)));
1071+
errhint("Terminate any old server processes associated with data directory \"%s\".",
1072+
refName)));
10771073
}
10781074
}
10791075

0 commit comments

Comments
 (0)