Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 5c5bcce

Browse files
committed
Fix another couple of outdated comments for MERGE RETURNING.
Oversights in c649fa2 which added RETURNING support to MERGE. Discussion: https://postgr.es/m/CAApHDvpqp6vtUzG-_josUEiBGyqnrnVxJ-VdF+hJLXjHdHzsyQ@mail.gmail.com
1 parent 83fc61c commit 5c5bcce

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/backend/utils/adt/ruleutils.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6016,7 +6016,7 @@ get_basic_select_query(Query *query, deparse_context *context,
60166016
/* ----------
60176017
* get_target_list - Parse back a SELECT target list
60186018
*
6019-
* This is also used for RETURNING lists in INSERT/UPDATE/DELETE.
6019+
* This is also used for RETURNING lists in INSERT/UPDATE/DELETE/MERGE.
60206020
*
60216021
* resultDesc and colNamesVisible are as for get_query_def()
60226022
* ----------

src/include/nodes/parsenodes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ typedef struct Query
154154
bool hasDistinctOn pg_node_attr(query_jumble_ignore);
155155
/* WITH RECURSIVE was specified */
156156
bool hasRecursive pg_node_attr(query_jumble_ignore);
157-
/* has INSERT/UPDATE/DELETE in WITH */
157+
/* has INSERT/UPDATE/DELETE/MERGE in WITH */
158158
bool hasModifyingCTE pg_node_attr(query_jumble_ignore);
159159
/* FOR [KEY] UPDATE/SHARE was specified */
160160
bool hasForUpdate pg_node_attr(query_jumble_ignore);

src/include/utils/portal.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@
6464
* supports holdable cursors (the Executor results can be dumped into a
6565
* tuplestore for access after transaction completion).
6666
*
67-
* PORTAL_ONE_RETURNING: the portal contains a single INSERT/UPDATE/DELETE
68-
* query with a RETURNING clause (plus possibly auxiliary queries added by
69-
* rule rewriting). On first execution, we run the portal to completion
67+
* PORTAL_ONE_RETURNING: the portal contains a single INSERT/UPDATE/DELETE/
68+
* MERGE query with a RETURNING clause (plus possibly auxiliary queries added
69+
* by rule rewriting). On first execution, we run the portal to completion
7070
* and dump the primary query's results into the portal tuplestore; the
7171
* results are then returned to the client as demanded. (We can't support
7272
* suspension of the query partway through, because the AFTER TRIGGER code

0 commit comments

Comments
 (0)